Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Update cron #78

Merged
merged 8 commits into from Jul 24, 2014
Merged

Update cron #78

merged 8 commits into from Jul 24, 2014

Conversation

pypingou
Copy link
Member

No description provided.


cnt = 0
updated = 0
for pkg in pkgdb2.lib.search_package(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using cnt here you could use enumerate(...)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that function, awesome! :)

@ralphbean
Copy link
Contributor

Other than the mostly aesthetic comment about enumerate(..), this looks good.

👍 to merge from me.

(BTW, I looked into it, and fedora-packages does in fact get its summaries from yum. So, we're safe against circular service dependencies for now ;p)

@pypingou
Copy link
Member Author

Thanks for the review and the suggestion @ralphbean

pypingou added a commit that referenced this pull request Jul 24, 2014
@pypingou pypingou merged commit 4047e01 into master Jul 24, 2014
@pypingou pypingou deleted the update_cron branch July 24, 2014 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants