New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit-Tests for the flask application and some of the scripts #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more robust and handle the situation where an arch or version would not be found without throwing an exception (as this case is covered in the code later).
But we need a Version object not just the string as we had so far.
The tests currently checks if it ran or not and its output in the log file
Once we have figured out which directory we are using, update the cache and use it
… FileDetail objects
This method allows retrieving all the HostCategoryDir objects stored in the database
I have been wondering if the fact that Atomic for rawhide has no clear numbering in its path until the objects directory could not be the cause of mirrormanager1 showing currently a release 64 for Fedora This new tree should help testing this
This argument will be used by the unit-tests to skip one check in the script, check preventing from testing the script correctly
The current tests are checking the behavior of the script with an incomplete set of data in the database
…elease We needed to create some more directories and a couple of repositories before we could actually update devel repositories to make them point to the release ones.
The move_install_repo isn't called anywhere
This will break on Windows but meh
@oddshocks, can you have a look at reviewing this? |
Woah, totally missed this notification. Sorry! Checking it out now. ... Looks good to me! Two small things I noticed that might be tweaked:
|
@oddshocks I adjusted the PR as you suggested |
I don't see any problem with merging this in, if you're good and ready. 👍 |
Let's do it then :) |
pypingou
added a commit
that referenced
this pull request
Mar 6, 2015
Unit-Tests for the flask application and some of the scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.