Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-Tests for the flask application and some of the scripts #14

Merged
merged 59 commits into from Mar 6, 2015
Merged

Conversation

pypingou
Copy link
Member

@pypingou pypingou commented Feb 7, 2015

No description provided.

This is more robust and handle the situation where an arch or version
would not be found without throwing an exception (as this case is
covered in the code later).
But we need a Version object not just the string as we had so far.
The tests currently checks if it ran or not and its output in the log
file
Once we have figured out which directory we are using, update the cache
and use it
This method allows retrieving all the HostCategoryDir objects stored in
the database
I have been wondering if the fact that Atomic for rawhide has no clear
numbering in its path until the objects directory could not be the cause of
mirrormanager1 showing currently a release 64 for Fedora

This new tree should help testing this
This argument will be used by the unit-tests to skip one check in the
script, check preventing from testing the script correctly
The current tests are checking the behavior of the script with an incomplete
set of data in the database
…elease

We needed to create some more directories and a couple of repositories
before we could actually update devel repositories to make them point to
the release ones.
The move_install_repo isn't called anywhere
This will break on Windows but meh
@ralphbean
Copy link
Contributor

@oddshocks, can you have a look at reviewing this?

@dtgay
Copy link
Contributor

dtgay commented Feb 24, 2015

Woah, totally missed this notification. Sorry! Checking it out now.

...

Looks good to me! Two small things I noticed that might be tweaked:

@pypingou
Copy link
Member Author

@oddshocks I adjusted the PR as you suggested

@dtgay
Copy link
Contributor

dtgay commented Mar 6, 2015

I don't see any problem with merging this in, if you're good and ready. 👍

@pypingou
Copy link
Member Author

pypingou commented Mar 6, 2015

Let's do it then :)

pypingou added a commit that referenced this pull request Mar 6, 2015
Unit-Tests for the flask application and some of the scripts
@pypingou pypingou merged commit 24f2eec into master Mar 6, 2015
@pypingou pypingou deleted the tests branch March 6, 2015 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants