Spec URL: http://ralph.fedorapeople.org//nodejs-yargs.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-yargs-1.2.6-1.fc20.src.rpm Description: Yargs be a node.js library fer hearties tryin' ter parse optstrings against their will where even the boo box be not enough to coerce them. This here module is fer scallywags lookin' ter plunder all the sunken -shipz of their --treasures thru program usage but be tired of optstrings disincling to acquiesce to yer requests. With yargs, ye be havin' a map that leads straight to yer treasure! Treasure of course, being a simple option hash.
Review: + mock build is successful for f22. - rpmlint output on rpms gave nodejs-yargs.noarch: W: spelling-error Summary(en_US) argv -> Argo nodejs-yargs.noarch: W: summary-ended-with-dot C Light-weight option parsing with an argv hash. nodejs-yargs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-yargs.noarch: W: spelling-error %description -l en_US tryin -> trying, train, tr yin nodejs-yargs.noarch: W: spelling-error %description -l en_US ter -> yer, tee, tr nodejs-yargs.noarch: W: spelling-error %description -l en_US optstrings -> opt strings, opt-strings, striplings nodejs-yargs.noarch: W: spelling-error %description -l en_US scallywags -> scalawags, scalawag nodejs-yargs.noarch: W: spelling-error %description -l en_US lookin -> looking, loo kin, loo-kin nodejs-yargs.noarch: W: spelling-error %description -l en_US shipz -> ship, ships, ship z nodejs-yargs.noarch: W: spelling-error %description -l en_US thru -> threw, throe, thrum nodejs-yargs.noarch: W: spelling-error %description -l en_US disincling -> disincline, disinclining, disciplining nodejs-yargs.noarch: W: spelling-error %description -l en_US havin -> having, haven, Gavin nodejs-yargs.noarch: W: invalid-license MIT/X11 nodejs-yargs.noarch: W: only-non-binary-in-usr-lib nodejs-yargs.noarch: W: dangling-symlink /usr/lib/node_modules/yargs/node_modules/minimist /usr/lib/node_modules/minimist nodejs-yargs.src: W: spelling-error Summary(en_US) argv -> Argo nodejs-yargs.src: W: summary-ended-with-dot C Light-weight option parsing with an argv hash. nodejs-yargs.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-yargs.src: W: spelling-error %description -l en_US tryin -> trying, train, tr yin nodejs-yargs.src: W: spelling-error %description -l en_US ter -> yer, tee, tr nodejs-yargs.src: W: spelling-error %description -l en_US optstrings -> opt strings, opt-strings, striplings nodejs-yargs.src: W: spelling-error %description -l en_US scallywags -> scalawags, scalawag nodejs-yargs.src: W: spelling-error %description -l en_US lookin -> looking, loo kin, loo-kin nodejs-yargs.src: W: spelling-error %description -l en_US shipz -> ship, ships, ship z nodejs-yargs.src: W: spelling-error %description -l en_US thru -> threw, throe, thrum nodejs-yargs.src: W: spelling-error %description -l en_US disincling -> disincline, disinclining, disciplining nodejs-yargs.src: W: spelling-error %description -l en_US havin -> having, haven, Gavin nodejs-yargs.src: W: invalid-license MIT/X11 2 packages and 0 specfiles checked; 0 errors, 28 warnings. + Source verified with upstream as (sha256sum) srpm tarball :fc41778fadfffb326f662325784b1f2488727c0f8a5e5f27a92c114bf8e7af63 upstream tarball :fc41778fadfffb326f662325784b1f2488727c0f8a5e5f27a92c114bf8e7af63 + rest looks following packaging guidelines. Suggestions: 1) Fix rpmlint warnings summary-ended-with-dot invalid-license MIT/X11 From LICENSE file it looks license tag should be "MIT" only. I will not block for this review for above issue. Please fix this and then import the package. APPROVED.
I see. Thanks Parag!
New Package SCM Request ======================= Package Name: nodejs-yargs Short Description: Light-weight option parsing with an argv hash. Upstream URL: https://npmjs.org/package/yargs Owners: ralph Branches: f21,f20,f19,epel7 InitialCC:
Git done (by process-git-requests).
nodejs-yargs-1.2.6-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-yargs-1.2.6-1.fc20
nodejs-yargs-1.2.6-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-yargs-1.2.6-1.fc19
Buildroot overrides have been created.
nodejs-yargs-1.2.6-1.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-yargs-1.2.6-1.fc20 has been pushed to the Fedora 20 stable repository.