New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It claims a "Scratch build succeeded", but it used the old source tarball #29
Comments
I guess that is because you're not using |
Using %version would make it too inconvenient to build snapshots and pre-releases. |
Hm.. I'm not sure there's a reasonable way for us to handle the case of your spec file. FWIW, you can keep %{version} in the source url and still handle pre-releases like this: |
Hm. As a feature for the-new-hotness, we could check that the tarball downloaded by 'fedpkg sources' and the tarball downloaded by 'spectool' after bumping the version are not the same tarball.
|
Yes, trying to "upgrade" the "sources" file cleanly would be a great idea. I'm sure other packages are affected, too. Obviously, working around the issue is what I'll do in this package. Now that it affects a service like this. I'm aware of various things one can do with macros/conditionals. And as of Audacious 3.6 the needed tarball appends "-gtk3" to version, which cannot be copied verbatim for RPM %version anyway. |
In response, @nirik says "I guess you could unpack it and diff -Nur". This sounds like a good plan to me. |
I've been trying to reproduce the original problem we had with github, I downloaded the sources via two places (tags and commit), here is the output:
So looks like we're good for these two links |
Hey, it's March 1st, not April 1st! You nearly got me, but I had doubts an upgrade would be that easy. See my comments at:
https://bugzilla.redhat.com/1197393
Latest upstream release: 3.6
Current version/release in rawhide: 3.5.2-1.fc22
http://koji.fedoraproject.org/koji/taskinfo?taskID=9103348
-> https://kojipkgs.fedoraproject.org//work/tasks/3350/9103350/build.log
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.Fyqt2F
The text was updated successfully, but these errors were encountered: