Implement and test comment anonymization over fedmsg (bodhi2). #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like #111 does for bodhi1. A new magic map is added for all models that can be used elsewhere called ``__anonymity_map__``: a dict that allows conditionally scrubbing fields from JSON responses if ``anonymize`` is set to ``True``. Currently, this is only fleshed out and tested for the ``Comment`` model, but I don't think we have a need to extend it anywhere else.
|
Looks good to me, thanks! |
lmacken
added a commit
that referenced
this pull request
Nov 11, 2014
Implement and test comment anonymization over fedmsg (bodhi2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #111 does for bodhi1.
A new magic map is added for all models that can be used elsewhere called
__anonymity_map__: a dict that allows conditionally scrubbing fieldsfrom JSON responses if
anonymizeis set toTrue.Currently, this is only fleshed out and tested for the
Commentmodel,but I don't think we have a need to extend it anywhere else.