Show project according to their update status #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif status == 'new': | ||
| query = query.filter( | ||
| Project.logs == None, | ||
| ) |
There was a problem hiding this comment.
maybe add an else: here that raises a ValueError since status is out of bounds?
|
@ralphbean what do you think of it this way? Do you still prefer an error thrown/displayed? |
pypingou
added a commit
that referenced
this pull request
Oct 18, 2014
Show project according to their update status
|
I left the second flash message to inform the user of what he/she is seeing. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.