Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new emails correctly #28

Closed
ralphbean opened this issue Sep 19, 2014 · 1 comment · Fixed by fedora-infra/fmn.consumer#52
Closed

Handle new emails correctly #28

ralphbean opened this issue Sep 19, 2014 · 1 comment · Fixed by fedora-infra/fmn.consumer#52
Labels
bug

Comments

@ralphbean
Copy link

I think this comes from when we create new accounts automatically for new packagers.. their email forwarding is not necessarily hooked up yet. Can we rely on their @fedoraproject.org address being usable?

  File "/usr/lib64/python2.6/threading.py", line 504 in __bootstrap
    self.__bootstrap_inner()
  File "/usr/lib64/python2.6/threading.py", line 532 in __bootstrap_inner
    self.run()
  File "/usr/lib64/python2.6/threading.py", line 484 in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.6/site-packages/twisted/python/threadpool.py", line 210 in _worker
    result = context.call(ctx, function, *args, **kwargs)
  File "/usr/lib64/python2.6/site-packages/twisted/python/context.py", line 59 in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib64/python2.6/site-packages/twisted/python/context.py", line 37 in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.6/site-packages/moksha/hub/api/consumer.py", line 190 in _work
    self.log.exception(message)
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/moksha/hub/api/consumer.py", line 188, in _work
    self.consume(message)
  File "/usr/lib/python2.6/site-packages/fmn/consumer/consumer.py", line 68, in consume
    self.work(session, raw_msg)
  File "/usr/lib/python2.6/site-packages/fmn/consumer/consumer.py", line 156, in work
    backend.handle(session, recipient, msg)
  File "/usr/lib/python2.6/site-packages/fmn/consumer/backends/mail.py", line 86, in handle
    self.send_mail(session, recipient, subject, content)
  File "/usr/lib/python2.6/site-packages/fmn/consumer/backends/mail.py", line 73, in send_mail
    email_message.as_string(),
  File "/usr/lib64/python2.6/smtplib.py", line 709, in sendmail
    raise SMTPRecipientsRefused(senderrs)
SMTPRecipientsRefused: {'rajalakshmi@fedoraproject.org': (550, '5.1.1 <rajalakshmi@fedoraproject.org>: Recipient address rejected: User unknown in local recipient table')}
@ralphbean
Copy link
Author

So, clearly we can't rely on their email being complete.

Another feature was added that should correctly pull their real email from FAS when they are created, but we still have a DB now full of these unusable email addresses.

We should add some code that catches this error, and:

  • Tries to look up their real email in FAS and replaces it in the fmn db.
  • If that fails, then it disables their fmn email preferences.. so that we stop getting these noisy tracebacks to sysadmin-datanommer.

ralphbean added a commit to fedora-infra/fmn.consumer that referenced this issue Mar 23, 2015
@ralphbean
Make mail handler deal with bad emails.
e5716e6 
Currently it just emails us.  This tries to:

1) get a good email from fas
2) failing that, disable the account.

Fixes fedora-infra/fmn#28.
@ralphbean ralphbean mentioned this issue Mar 23, 2015
Merged
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#28 from fedora-infra/feature/lock-on-…
1c6a127 
…pref-update

Throw a lock around cached preference refresh.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#28 from fedora-infra/feature/hotness
cdeb629 
Include rules for the-new-hotness.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Actually add rules for the-new-hotness.
d8b6ca6 
These were forgotten in fedora-infra#28 -- whoops!
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#28 from fedora-infra/feature/hint-dec…
9ef6884 
…oration-fix

Fix hint decoration.
jeremycline pushed a commit that referenced this issue Apr 26, 2017
@ralphbean
Merge pull request #28 from fedora-infra/feature/context-page-reorgan…
3106cd9 
…ization

Context page reorganization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make mail handler deal with bad emails. fedora-infra/fmn.consumer
1 participant
@ralphbean