New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a nicer changelog for the scratch task srpm. #22
Conversation
This should fix #19.
@voxik, does this look like it will do it for you? |
@@ -96,8 +96,8 @@ def handle(self, package, upstream, version, rhbz): | |||
cmd = [ | |||
'/usr/bin/rpmdev-bumpspec', | |||
'--new', upstream, | |||
'-c', '"Latest upstream, %s for #%s"' % (upstream, rhbz), | |||
'-u', '"%s"' % self.userstring, | |||
'-c', 'Update to %s (#%s)' % (upstream, rhbz.bug_id), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be #%d
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why, yes it should, my type-oriented friend.
(fwiw, the %s
works.. but %d
would be more explicit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why, yes it should, my type-oriented friend.
In a dependently-typed language (Idris, Agda, Coq, etc.) you could detect that mismatch at compile time ;). Not in Haskell though. :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ralphbean If you want to see how that works (it's really neat): https://www.youtube.com/watch?v=fVBck2Zngjo
Looks good if I can parse the code correctly 👍 |
👍 for me as well |
Thanks both! |
Generate a nicer changelog for the scratch task srpm.
This should fix #19.