Rely on fedmsg-provided queue. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedbadges implemented this little callLater mechanism a long time ago before fedmsg and moksha provided a much more sophisticated queueing and monitoring framework. This callLater logic actually serves to **hide** how many messages are in the fedbadges backlog. By removing it, we can get a better sense of what the consumer is doing.
|
👍 for me |
ralphbean
added a commit
that referenced
this pull request
Sep 13, 2014
Rely on fedmsg-provided queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fedbadges implemented this little callLater mechanism a long time ago
before fedmsg and moksha provided a much more sophisticated queueing and
monitoring framework. Inadvertently, this callLater logic actually serves to hide how
many messages are in the fedbadges backlog. By removing it, we can get a
better sense of what the consumer is doing.