Bug 1164561 - fedpkg update doesn't work through HTTP proxies
Summary: fedpkg update doesn't work through HTTP proxies
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-requests
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Arun S A G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-16 13:43 UTC by Richard W.M. Jones
Modified: 2015-09-17 19:32 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-09-17 17:27:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Richard W.M. Jones 2014-11-16 13:43:10 UTC
Description of problem:

$ fedpkg update
Creating a new update for  libguestfs-1.28.3-2.fc21 
Traceback (most recent call last):
  File "/usr/bin/bodhi", line 532, in <module>
    main()
  File "/usr/bin/bodhi", line 225, in main
    data = bodhi.save(**update_args)
  File "/usr/lib/python2.7/site-packages/fedora/client/bodhi.py", line 111, in save
    'bugs': bugs,
  File "/usr/lib/python2.7/site-packages/fedora/client/baseclient.py", line 369, in send_request
    auth_params=auth_params, retries=retries, timeout=timeout)
  File "/usr/lib/python2.7/site-packages/fedora/client/proxyclient.py", line 397, in send_request
    timeout=timeout,
  File "/usr/lib/python2.7/site-packages/requests/api.py", line 88, in post
    return request('post', url, data=data, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/api.py", line 44, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 456, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 559, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 382, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: hostname 'cache.home.annexia.org' doesn't match either of '*.fedoraproject.org', 'fedoraproject.org'
Could not generate update request: Command 'bodhi --new --release f21 --file bodhi.template libguestfs-1.28.3-2.fc21 --username rjones' returned non-zero exit status 1


'cache.home.annexia.org' is the proxy.  It's a bug to try
to check the proxy name against the SSL cert.

Version-Release number of selected component (if applicable):

python-fedora-0.3.36-2.fc21.noarch

How reproducible:

100%

Steps to Reproduce:
1. Set http_proxy & https_proxy.
2. fedpkg update

Comment 1 Jan Kratochvil 2015-01-25 07:31:11 UTC
Also affecting: fedora-packager-setup

Comment 2 Jon Stanley 2015-01-26 14:59:09 UTC
This bug seems to be in python-requests rather than in python-fedora. Reassigning....

Comment 3 Richard W.M. Jones 2015-02-24 09:42:39 UTC
This affects fedora-review too:

02-24 09:40 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 23
2, in run
    self._do_run(outfile)
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 22
2, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 96, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 115, in _run_checks
    writedown=not Settings.no_report)
  File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 377, in run_checks
    run_check(name)
  File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 351, in run_check
    check.run()
  File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic.py", line 1501, in run
    if already_exist(name.lower()) or already_exist(name):
  File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic.py", line 1495, in already_exist
    p.get_package(name)
  File "/usr/lib/python2.7/site-packages/pkgdb2client/__init__.py", line 544, in get_package
    return self.handle_api_call('/package/', params=args)
  File "/usr/lib/python2.7/site-packages/pkgdb2client/__init__.py", line 346, in handle_api_call
    response = self.call_api(path, params, data)
  File "/usr/lib/python2.7/site-packages/pkgdb2client/__init__.py", line 299, in call_api
    params=params)
  File "/usr/lib/python2.7/site-packages/pkgdb2client/__init__.py", line 167, in __send_request
    verify=not self.insecure,
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 456, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 559, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 382, in send
    raise SSLError(e, request=request)
SSLError: hostname 'cache.home.annexia.org' doesn't match either of '*.fedoraproject.org', 'fedoraproject.org'

Comment 4 Taylor Braun-Jones 2015-04-03 13:21:40 UTC
This bug makes is difficult for many corporate users to contribute to the Fedora project. Can we set the priority to high for this bug?

Comment 5 Richard W.M. Jones 2015-09-17 17:18:41 UTC
I believe this bug is now fixed.  I'm using:

python-requests-2.7.0-1.fc22.noarch

Comment 6 Ralph Bean 2015-09-17 17:27:32 UTC
Great to hear.  I'll close the bug, but if anyone else who has commented here still experiences it, please re-open so we can investigate.

For those curious about how python-requests and python-urllib3 handle proxies, this blog post from 2013 by one of the core maintainers is a good starting point:  https://lukasa.co.uk/2013/07/Python_Requests_And_Proxies/

Comment 7 Taylor Braun-Jones 2015-09-17 17:30:46 UTC
Awesome! Is there any chance this fix can make it into RHEL7 as a bugfix update?

Comment 8 Ralph Bean 2015-09-17 19:32:25 UTC
Taylor, I think that will require a separate bug filed on the python-requests/python-urllib3 packages for rhel7.


Note You need to log in before you can comment on or make changes to this bug.